Async connect context manager support - approach 1 - idempotent __aenter__ through checking if conn closed #2614
+2,357
−370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Berkay Öztürk <[email protected]> (cherry picked from commit 87c623e)
…er for async with SessionWithProxy
Comment on lines
+32
to
+42
| def send(self, arg: Any) -> Any: | ||
| """Send a value into the wrapped coroutine.""" | ||
| return self._coro.send(arg) | ||
|
|
||
| def throw(self, *args: Any, **kwargs: Any) -> Any: | ||
| """Throw an exception into the wrapped coroutine.""" | ||
| return self._coro.throw(*args, **kwargs) | ||
|
|
||
| def close(self) -> None: | ||
| """Close the wrapped coroutine.""" | ||
| return self._coro.close() |
There was a problem hiding this comment.
Are those methods used somewhere?
Base automatically changed from
cherrypicks-to-aio-connector-part23a
to
dev/aio-connector
October 29, 2025 11:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach 1 - idempotent aenter through checking if conn closed.
Main benefit - calling SnowflakeConnection.aenter in the snowflake.connector.aio.connect.aenter - we can feel safe from missing some logic there.
Main drawback - will always conn.is_closed() be reliable.
Analogous to: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/client.py#L1376-L1412